Archive old migrations #1699
Merged
Archive old migrations #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also: f5a48c5 These migrations have already been built and released with Bottlerocket releases and don't need to be built again. The build system and os package currently build everything in the migrations directory, which can take a significant amount of time with unneeded migrations. Their source is still useful as a reference, and the files are small, so it's worthwhile keeping them in-tree rather than having to search git history.
bcressey
approved these changes
Aug 6, 2021
etungsten
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, the previous archiving: #1540. This makes the same change.
Testing done:
This took build time of the os package from ~232 seconds down to ~197.
The contents of the migrations rpm went from all current migrations:
To just the directory, as expected:
I also confirmed the resulting image is still healthy.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.